search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.63k stars 1.63k forks source link

[bug] Launcher unable to properly store artifacts due to forcePathStyle mismatch #11280

Closed HumairAK closed 1 month ago

HumairAK commented 1 month ago

Quoting @zazulam in this thread:

@HumairAK prior to that PR forcePathStyle was defaulted to true, so for the Bucket URL for a local deployment it would resolve to http://minio_ip:9000/bucket_name/... Now in the driver, it does not pass a value for forcePathStyle when creating the SessionInfo used for the root dag so effectively when it gets resolved downstream it would be false resulting in the format http://bucket_name.minio_ip:port/bucket_name/... which causes the error when attempting to store artifacts. This error arises when building the launcher image off the current master branch. Lmk if you think it should be added as a separate PR.

Expected result

Launcher should run on main branch without issues when forcePathStyle is not set.

Impacted by this bug? Give it a 👍.

HumairAK commented 1 month ago

/assign @zazulam

google-oss-prow[bot] commented 1 month ago

@HumairAK: GitHub didn't allow me to assign the following users: zazulam.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubeflow/pipelines/issues/11280#issuecomment-2402413758): >/assign @zazulam Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.