kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.63k stars 1.63k forks source link

feat(cli): expose existing_token client property #11400

Closed tumido closed 3 days ago

tumido commented 1 week ago

Description of your changes:

This PR exposes existing_token option of kfp.Client to the CLI.

Resolves: https://github.com/kubeflow/pipelines/issues/11399

Checklist:

google-oss-prow[bot] commented 1 week ago

Hi @tumido. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tumido commented 1 week ago

@hbelmiro can you please approve the CI to be run on this? It seems ok-to-test is not enough and some additional button clicking or keyboard smashing is still required. 🤷‍♂️ 🙂

HumairAK commented 3 days ago

/lgtm /approve

@tumido thank you! if you are up for it there are some other low hanging fruits here as well that can help with connecting against endpoints, I'm mainly thinking of ssl_ca_cert and verify_ssl if you're up for it 🥲

google-oss-prow[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/OWNERS](https://github.com/kubeflow/pipelines/blob/master/sdk/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment