[SDK] Minor fix in wait_for_job_conditions with job_kind python training API

saileshd1402 commented 2 months ago

What this PR does / why we need it: This PR fixes a minor bug in the wait_for_job_conditions function of the python training SDK

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Fixes #

Checklist:

[ ] Docs included if any changes are user facing

Bug

Encountered this bug when testing the create-tfjob.ipynb notebook example
When job_kind (which is not PyTorch job kind) is passed in wait_for_job_conditions the SDK throws a ValueError. Example code: TrainingClient(namespace=namespace).wait_for_job_conditions(name, job_kind=constants.TFJOB_KIND)

Error:

ValueError: Job must be one of these types: KubeflowOrgV1PyTorchJob ('KubeflowOrgV1TFJob', 'KubeflowOrgV1PyTorchJob', 'KubeflowOrgV1XGBoostJob', 'KubeflowOrgV1MPIJob', 'KubeflowOrgV1PaddleJob', 'KubeflowOrgV1JAXJob')

Fix

When wait_for_job_conditions calls the get_job_conditions function, since job_kind is not passed, it takes the default value of PyTorchJob from here which leads to the error.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10974037171

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 10963743211:	0.0%
Covered Lines:	66
Relevant Lines:	66

💛 - Coveralls

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/python/OWNERS](https://github.com/kubeflow/training-operator/blob/master/sdk/python/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubeflow / training-operator