kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes
https://www.kubeflow.org/docs/components/training
Apache License 2.0
1.62k stars 701 forks source link

[SDK] test: add unit test for get_job_logs method of the training_client #2275

Closed seanlaii closed 1 month ago

seanlaii commented 1 month ago

What this PR does / why we need it: New unit test for get_job_logs function

To verify run:

pytest -v sdk/python/kubeflow/training/api/training_client_test.py -k test_get_job_logs

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Ref: #2161

Checklist:

seanlaii commented 1 month ago

Hi @andreyvelich, please help review it when you are available. Thank you!

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11300697873

Details


Totals Coverage Status
Change from base Build 11297771461: 0.0%
Covered Lines: 66
Relevant Lines: 66

💛 - Coveralls
andreyvelich commented 1 month ago

@seanlaii Also, please rebase your PR so we can merge it.

seanlaii commented 1 month ago

@seanlaii Also, please rebase your PR so we can merge it.

Rebased. Thanks for reviewing the PR.

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/python/OWNERS](https://github.com/kubeflow/training-operator/blob/master/sdk/python/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment