kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

unversioned kubernetes spec #143

Closed tomplus closed 4 years ago

tomplus commented 4 years ago

Hi.

This change kubernetes/kubernetes#84654 removed a name of version from swagger.json, which may appear in generated code. For example the Python Client is affected. Now we'll get 'OpenAPI spec version: unversioned' in each file if code is generated by openapi-generator from release branches.

To make it work again we have to switch to use git tags to fetch spec and update version info.

$ curl -s https://raw.githubusercontent.com/kubernetes/kubernetes/release-1.14/api/openapi-spec/swagger.json | jq .info.version
"v1.14.11"
$ curl -s https://raw.githubusercontent.com/kubernetes/kubernetes/release-1.15/api/openapi-spec/swagger.json | jq .info.version
"unversioned"

cc: @roycaihw