Closed yati1998 closed 2 weeks ago
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yati1998 Once this PR has been reviewed and has the lgtm label, please assign jingxu97 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @yati1998. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@Madhu-1 @xing-yang please take a look. I tested the changes and now the volumegroupdeletion is not getting stuck even after multiple deletions
/ok-to-test
@yati1998 Is there an issue opened for this bug fix? If there is one, please add to your PR description.
this commit adds check to continue deleting the volumegroupsnapshot in case there are no snapshotcontent found under that group.
https://github.com/kubernetes-csi/external-snapshotter/issues/1035