search

kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
501 stars 374 forks source link

Remove volumeGroupSnapshotRef immutable validation rule #1184

Closed xing-yang closed 2 weeks ago

xing-yang commented 2 weeks ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: We need to remove the validation rule that ensures volumeGroupSnapshotRef is immutable. This is because that UID needs to be set by the snapshot controller after volumeGroupSnapshotRef is populated with name and namespace for pre-provisioned VolumeGroupSnapshotContent.

This immutable validation rule was added as part of this PR https://github.com/kubernetes-csi/external-snapshotter/pull/1073 to use CEL to replace the validation added in the validation webhook:

    // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="volumeGroupSnapshotRef is immutable"

However, in the original validation webhook, we never had this rule: https://github.com/kubernetes-csi/external-snapshotter/blob/v7.0.2/pkg/validation-webhook/validation.go#L52 With this rule, the snapshot controller won't be able to set UID for volumeGroupSnapshotRef after it was populated with name and namespace initially. So we need to remove this rule.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove the rule that ensures volumeGroupSnapshotRef is immutable. UID needs to be set by the snapshot controller after volumeGroupSnapshotRef is populated with name and namespace for pre-provisioned VolumeGroupSnapshotContent.
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/OWNERS)~~ [xing-yang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
leonardoce commented 2 weeks ago

/assign

leonardoce commented 2 weeks ago

I tested the volume group snapshot static and dynamic provisioning, and everything is fine.

leonardoce commented 2 weeks ago

/lgtm