kubernetes-csi / external-snapshotter

Sidecar container that watches Kubernetes Snapshot CRD objects and triggers CreateSnapshot/DeleteSnapshot against a CSI endpoint.
Apache License 2.0
501 stars 374 forks source link

Bump go 1.23.1 #1208

Open huww98 opened 1 day ago

huww98 commented 1 day ago

What type of PR is this? /kind cleanup

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Bump prow.sh to upgrade go version be consistent with go.mod

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Our internal CI tries to compile this repo with the Golang version specified in prow.sh. But https://github.com/kubernetes-csi/external-snapshotter/pull/1156 breaks us.

/cc @pohly

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98 Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[release-tools/OWNERS](https://github.com/kubernetes-csi/external-snapshotter/blob/master/release-tools/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 day ago

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
huww98 commented 1 day ago

/cc @jsafrane @xing-yang

mowangdk commented 22 minutes ago

/ok-to-test

mowangdk commented 22 minutes ago

/lgtm