search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.12k stars 596 forks source link

Add missing cluster labels and aggregations for apiserver alerts #889

Closed chess-knight closed 2 months ago

chess-knight commented 9 months ago

Also, remove unused variable kubeAPILatencyWarningSeconds, which was not deleted in kubernetes-monitoring/kubernetes-mixin#451

github-actions[bot] commented 2 months ago

This PR has been automatically marked as stale because it has not had any activity in the past 30 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity. Thank you for your contributions!

chess-knight commented 2 months ago

Hi @povilasv, can you please look at this?

dohnto commented 2 months ago

@skl Thanks for the review, is anything blocking from merging PR 🙏 ?

skl commented 2 months ago

@povilasv lgtm for merging if you get a moment