kubernetes-retired / contrib

[EOL] This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.
Apache License 2.0
2.46k stars 1.68k forks source link

fix absend response by adding small delay in zookeeper check scripts #3011

Closed langemar closed 5 years ago

langemar commented 5 years ago

Running the pipes will close nc after sending commands immediately, which might not let zk time to respond to the request. Given a small delay fix false positives.

Not waiting for the response will (in case of zkOk) result in a lot of failing liveness probes and will restart the pod unnecessarily.

k8s-ci-robot commented 5 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: langemar To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: bprashanth

If they are not already assigned, you can assign the PR to them by writing /assign @bprashanth in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[statefulsets/zookeeper/OWNERS](https://github.com/kubernetes/contrib/blob/master/statefulsets/zookeeper/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
langemar commented 5 years ago

CLA