Closed langemar closed 5 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: langemar To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: bprashanth
If they are not already assigned, you can assign the PR to them by writing /assign @bprashanth
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
CLA
Running the pipes will close nc after sending commands immediately, which might not let zk time to respond to the request. Given a small delay fix false positives.
Not waiting for the response will (in case of zkOk) result in a lot of failing liveness probes and will restart the pod unnecessarily.