search

kubernetes-retired / heapster

[EOL] Compute Resource Usage Analysis and Monitoring of Container Clusters
Apache License 2.0
2.63k stars 1.25k forks source link

Fix stackdriver metrics for node memory using wrong metric type #2027

Closed serathius closed 6 years ago

serathius commented 6 years ago

Because stackdriver is accessing metric with wrong field (IntValue instead of FloatValue) metric is reported as 0. This PR fixes this behaviour Tested on gcp /cc @kawych

kawych commented 6 years ago

/ok-to-test /lgtm

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[metrics/sinks/stackdriver/OWNERS](https://github.com/kubernetes/heapster/blob/master/metrics/sinks/stackdriver/OWNERS)~~ [kawych] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment