kubernetes-retired / heapster

[EOL] Compute Resource Usage Analysis and Monitoring of Container Clusters
Apache License 2.0
2.63k stars 1.25k forks source link

Fix typo: Ponit -> Point #2107

Closed SataQiu closed 6 years ago

SataQiu commented 6 years ago

What this PR does Fix typo: Ponit -> Point

k8s-ci-robot commented 6 years ago

Hi @SataQiu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SataQiu commented 6 years ago

/assign @andyxning

andyxning commented 6 years ago

/ok-to-test

andyxning commented 6 years ago

@SataQiu Run make sanitize

SataQiu commented 6 years ago

/test pull-heapster-unit

andyxning commented 6 years ago

@SataQiu According to the error log.

I1121 05:08:26.469] Run gofmt on the following files: I1121 05:08:26.470] ./metrics/sources/summary/summary_test.go ./metrics/sinks/opentsdb/driver_test.go ./metrics/sinks/wavefront/driver_test.go I1121 05:08:26.470] Makefile:50: recipe for target 'sanitize' failed W1121 05:08:26.476] make: *** [sanitize] Error 1

You need to run make sanitize to find that you need to run gofmt ./metrics/sources/summary/summary_test.go ./metrics/sinks/opentsdb/driver_test.go ./metrics/sinks/wavefront/driver_test.go

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SataQiu To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: andyxning

If they are not already assigned, you can assign the PR to them by writing /assign @andyxning in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/heapster/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SataQiu commented 6 years ago

@andyxning thank you!

andyxning commented 6 years ago

/retest

andyxning commented 6 years ago

@SataQiu

I1121 10:05:31.474] # k8s.io/heapster/common/kafka I1121 10:05:31.474] common/kafka/glogadapter.go:29: missing ... in args forwarded to print-like function I1121 10:05:31.474] common/kafka/glogadapter.go:33: missing ... in args forwarded to printf-like function I1121 10:05:31.474] common/kafka/glogadapter.go:37: missing ... in args forwarded to print-like function I1121 10:05:31.474] # k8s.io/heapster/events/sinks/riemann I1121 10:05:31.475] events/sinks/riemann/driver.go:106: Warningf call has arguments but no formatting directives I1121 10:05:31.475] events/sinks/riemann/driver.go:140: Warningf call has arguments but no formatting directives I1121 10:05:31.475] # k8s.io/heapster/metrics/sinks/riemann I1121 10:05:31.475] metrics/sinks/riemann/driver.go:78: Warningf call has arguments but no formatting directives I1121 10:05:31.475] metrics/sinks/riemann/driver.go:132: Warningf call has arguments but no formatting directives I1121 10:05:31.475] # k8s.io/heapster/metrics/sources/kubelet I1121 10:05:31.475] metrics/sources/kubelet/kubelet.go:226: Verbose.Infof call needs 1 arg but has 2 args

You need to adjust the go source file according to the error message.

andyxning commented 6 years ago

image image image

andyxning commented 6 years ago

/test pull-heapster-e2e

krzyzacy commented 6 years ago

/retest

krzyzacy commented 6 years ago

which go version is heapster using? rerun gofmt I guess?

andyxning commented 6 years ago

/retest

andyxning commented 6 years ago

/retest

andyxning commented 6 years ago

@SataQiu Sorry, you first need to address the conflicts. :(

SataQiu commented 6 years ago

/retest

krzyzacy commented 6 years ago

/retest just pushed the image

krzyzacy commented 6 years ago

/retest