Closed SataQiu closed 6 years ago
Hi @SataQiu. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @andyxning
/ok-to-test
@SataQiu Run make sanitize
/test pull-heapster-unit
@SataQiu According to the error log.
I1121 05:08:26.469] Run gofmt on the following files: I1121 05:08:26.470] ./metrics/sources/summary/summary_test.go ./metrics/sinks/opentsdb/driver_test.go ./metrics/sinks/wavefront/driver_test.go I1121 05:08:26.470] Makefile:50: recipe for target 'sanitize' failed W1121 05:08:26.476] make: *** [sanitize] Error 1
You need to run make sanitize
to find that you need to run gofmt ./metrics/sources/summary/summary_test.go ./metrics/sinks/opentsdb/driver_test.go ./metrics/sinks/wavefront/driver_test.go
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SataQiu To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: andyxning
If they are not already assigned, you can assign the PR to them by writing /assign @andyxning
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@andyxning thank you!
/retest
@SataQiu
I1121 10:05:31.474] # k8s.io/heapster/common/kafka I1121 10:05:31.474] common/kafka/glogadapter.go:29: missing ... in args forwarded to print-like function I1121 10:05:31.474] common/kafka/glogadapter.go:33: missing ... in args forwarded to printf-like function I1121 10:05:31.474] common/kafka/glogadapter.go:37: missing ... in args forwarded to print-like function I1121 10:05:31.474] # k8s.io/heapster/events/sinks/riemann I1121 10:05:31.475] events/sinks/riemann/driver.go:106: Warningf call has arguments but no formatting directives I1121 10:05:31.475] events/sinks/riemann/driver.go:140: Warningf call has arguments but no formatting directives I1121 10:05:31.475] # k8s.io/heapster/metrics/sinks/riemann I1121 10:05:31.475] metrics/sinks/riemann/driver.go:78: Warningf call has arguments but no formatting directives I1121 10:05:31.475] metrics/sinks/riemann/driver.go:132: Warningf call has arguments but no formatting directives I1121 10:05:31.475] # k8s.io/heapster/metrics/sources/kubelet I1121 10:05:31.475] metrics/sources/kubelet/kubelet.go:226: Verbose.Infof call needs 1 arg but has 2 args
You need to adjust the go source file according to the error message.
/test pull-heapster-e2e
/retest
which go version is heapster using? rerun gofmt I guess?
/retest
/retest
@SataQiu Sorry, you first need to address the conflicts. :(
/retest
/retest just pushed the image
/retest
What this PR does Fix typo: Ponit -> Point