kubernetes-sigs / blob-csi-driver

Azure Blob Storage CSI driver
Apache License 2.0
123 stars 83 forks source link

feat: install blobfuse2 for arm64 #1633

Closed explsd closed 1 month ago

explsd commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it: Installs blobfuse2 for arm64 build of the blobplugin docker image. Needed to support using fuse2 protocol on arm64.

Which issue(s) this PR fixes: Fixes #1618

Requirements:

Special notes for your reviewer:

Release note:

none
linux-foundation-easycla[bot] commented 1 month ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: explsd Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/blob-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

Welcome @explsd!

It looks like this is your first PR to kubernetes-sigs/blob-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blob-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

Hi @explsd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andyzhangx commented 1 month ago

/ok-to-test

andyzhangx commented 1 month ago

/test pull-blob-csi-driver-e2e-arm64

andyzhangx commented 1 month ago

/retest

k8s-ci-robot commented 1 month ago

@explsd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-blob-csi-driver-e2e-arm64 26271aa319f40ee198bfb030377c473336923c33 link true /test pull-blob-csi-driver-e2e-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
andyzhangx commented 1 month ago

/cherrypick release-1.24

andyzhangx commented 1 month ago

/cherrypick release-1.23

andyzhangx commented 1 month ago

/cherrypick release-1.22

k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1636

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1633#issuecomment-2410959166): >/cherrypick release-1.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: new pull request created: #1637

In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1633#issuecomment-2410959335): >/cherrypick release-1.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 1 month ago

@andyzhangx: #1633 failed to apply on top of branch "release-1.22":

Applying: feat: install blobfuse2 for arm64
Using index info to reconstruct a base tree...
M   pkg/blobplugin/Dockerfile
Falling back to patching base and 3-way merge...
Auto-merging pkg/blobplugin/Dockerfile
CONFLICT (content): Merge conflict in pkg/blobplugin/Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: install blobfuse2 for arm64
In response to [this](https://github.com/kubernetes-sigs/blob-csi-driver/pull/1633#issuecomment-2410959466): >/cherrypick release-1.22 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.