search

kubernetes-sigs / cli-experimental

Experimental Kubectl libraries and commands.
Apache License 2.0
85 stars 221 forks source link

Fix typo in example Bash command #357

Closed lindhe closed 4 days ago

lindhe commented 1 year ago

It does not work with spaces.

k8s-ci-robot commented 1 year ago

Welcome @lindhe!

It looks like this is your first PR to kubernetes-sigs/cli-experimental 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-experimental has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lindhe Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cli-experimental/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-triage-robot commented 10 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lindhe commented 10 months ago

Please keep it open. I think it's a trivial fix once someone gives it a look.

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

lindhe commented 9 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lindhe commented 6 months ago

/remove-lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lindhe commented 3 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lindhe commented 1 week ago

/remove-lifecycle stale

lindhe commented 1 week ago

@natasha41575 mind giving this a quick review? I hope it should be fairly straight-forward. 🙂

soltysh commented 4 days ago

Per https://www.kubernetes.dev/docs/guide/pull-requests/#trivial-edits

I'm considering this a trivial change. Let's fix this while addressing something else.

/close

k8s-ci-robot commented 4 days ago

@soltysh: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/cli-experimental/pull/357#issuecomment-2498299720): >Per https://www.kubernetes.dev/docs/guide/pull-requests/#trivial-edits > >I'm considering this a trivial change. Let's fix this while addressing something else. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lindhe commented 3 days ago

Fair enough. I'll see what I can do.

I would have appreciated getting that input a year earlier, but I know there's a real crunch on maintainers for Kubernetes so it's understandable.