search

kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
297 stars 427 forks source link

Switch to gen2 reference images #2296

Closed mboersma closed 1 year ago

mboersma commented 2 years ago

/kind feature

Describe the solution you'd like

The CAPZ reference images use Azure generation 2 VMs by default.

Describe alternatives you've considered

We could leave gen1 as the default. We could publish both gen1 and gen2 reference images.

Additional context

See also #1003 and https://github.com/kubernetes-sigs/image-builder/pull/878#discussion_r866291520

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mboersma commented 2 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2296#issuecomment-1374890107): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffais commented 1 week ago

Hi @mboersma, gen2 reference images are still missing. Do you know why?

mboersma commented 1 week ago

Hi @ffais! I guess we never really committed to switching to -gen2 images by default, and this work item fell by the wayside.

The reference images are primarily for tests, and we try to keep the matrix of (k8s version * OS distro) small to keep costs down. There hasn't been a business justification that drove us to complete this switch.

Our strong recommendation if you're using CAPZ is to build and host your own images, because we may not publish every variation you need, and because we don't patch them with security fixes or other updates.

Also note that CAPZ switched from defaulting to Azure Marketplace to a community gallery in the main branch.

ffais commented 1 week ago

Thanks for the clarification, everything is clearer now.