kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure

https://capz.sigs.k8s.io/

Apache License 2.0

295 stars 425 forks source link

Bump prometheus and otel packages when k8s.io packages are updated #4860

Open mboersma opened 5 months ago

mboersma commented 5 months ago

/kind cleanup

What needs cleanup:

Bump dependency versions

Describe the solution you'd like

Currently because of Go vendoring dependencies upstream in CAPI, the project can't ingest newer versions of otel or the prometheus client libraries. The fix for that is supposedly upstream in CAPI main now, but may wait for a new minor release before it trickles down.

This issue is to remind us to revisit this once we've updated vendoring, specifically k8s.io packages.

Anything else you would like to add:

For more context, see:

nojnhuh commented 5 months ago

This gives me the impression that maybe it's okay to ignore Prometheus dependencies if we're confident they'll get bumped transitively: https://github.com/kubernetes-sigs/cluster-api/blob/a7a32ed5705d991af0332d856f61dbcdd54abd94/.github/dependabot.yaml#L40-L41

This isn't something we would inherit automatically from CAPI, so I'll open a PR to port this over to here. I'll leave this issue open even after merging that as a reminder.

To future generations: If go.mod on the main branch ever lists github.com/prometheus/common at v0.48.0 or higher this issue can be closed.

nojnhuh commented 5 months ago

This isn't something we would inherit automatically from CAPI, so I'll open a PR to port this over to here.

4861

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

nojnhuh commented 2 months ago

I think the otel dependencies at least will be ironed out in #5057, prometheus will still be an issue I think until we pull in k8s 1.31.

This is what we have queued up so far in #5057: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/abe85cbe9854456995901be0359d8c0a574756a7/go.mod#L225-L229

/remove-lifecycle stale