kubernetes-sigs / cluster-api-provider-cloudstack

A Kubernetes Cluster API Provider implementation for Apache CloudStack.
https://cluster-api-cloudstack.sigs.k8s.io/
Apache License 2.0
37 stars 35 forks source link

Update make target for staging release #335

Closed g-gaston closed 11 months ago

g-gaston commented 11 months ago

Description of changes:

The images are built and pushed by a prow job, we don't need to do it manually.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

netlify[bot] commented 11 months ago

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
Latest commit 4e53ae79b6d0839e1b230f212bf65d54b011d276
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/6597fe5686b20e00085b6b97
Deploy Preview https://deploy-preview-335--kubernetes-sigs-cluster-api-cloudstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/blob/main/OWNERS)~~ [g-gaston] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rohityadavcloud commented 11 months ago

/assign @weizhouapache

/ok-to-test /lgtm

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7ce8a27) 25.45% compared to head (4e53ae7) 25.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #335 +/- ## ======================================= Coverage 25.45% 25.45% ======================================= Files 59 59 Lines 5555 5555 ======================================= Hits 1414 1414 Misses 4002 4002 Partials 139 139 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.