search

kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 79 forks source link

Update golang version to 1.21.12 #1880

Closed Amulyam24 closed 2 months ago

Amulyam24 commented 2 months ago

What this PR does / why we need it: Update golang version to 1.21.12 to fix trivy vulnerabilities

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update golang version to 1.21.12
netlify[bot] commented 2 months ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 5ae8dd8edaf180c21ca1f2e571d4329a7c820085
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/668e56ce560a4f0008cd31ea
Deploy Preview https://deploy-preview-1880--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Amulyam24 commented 2 months ago

This PR needs to be cherry-picked to release-0.8 and release-0.7

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [Prajyot-Parab] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Prajyot-Parab commented 2 months ago

/cherry-pick release-0.8

Prajyot-Parab commented 2 months ago

/cherry-pick release-0.7

k8s-infra-cherrypick-robot commented 2 months ago

@Prajyot-Parab: #1880 failed to apply on top of branch "release-0.7":

Applying: Update golang version to 1.21.12
Using index info to reconstruct a base tree...
M   Makefile
M   hack/ccm/Makefile
Falling back to patching base and 3-way merge...
Auto-merging hack/ccm/Makefile
CONFLICT (content): Merge conflict in hack/ccm/Makefile
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update golang version to 1.21.12
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1880#issuecomment-2265957490): >/cherry-pick release-0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 2 months ago

@Prajyot-Parab: new pull request created: #1902

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1880#issuecomment-2265957399): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.