Open sbueringer opened 1 year ago
@vincepri @fabriziopandini @ykakarap
The unit tests sounds sufficient and pretty straightforward to me, WDYT?
Yup, unit test looks like a good idea. +1. Since we will use envtest with the defaulting webhook it will closely reflect the real world case too.
/triage accepted /help 💯 this will be very useful!
@fabriziopandini: This request has been marked as needing help from a contributor.
Please ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help
command.
Let's see if some takes this over. I added it to the v1.5 milestone to ensure we'll implement it until then.
I would take over if nobody volunteers until then.
This issue has not been updated in over 1 year, and should be re-triaged.
You can:
/triage accepted
(org members only)/close
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/
/remove-triage accepted
/triage accepted
We repeatedly had the issue that we added new defaulting to KubeadmConfigSpec fields, which lead to rollouts in KCP after CAPI upgrade:
6093
8124
The goal of this issue is to add some sort of validation that we can run as part of presubmits to ensure this doesn't happen again.
We basically want to validate that all defaulting that we implement for
KubeadmConfigSpec
is done inDefaultKubeadmConfigSpec
and not via OpenAPI.Some ideas:
KubeadmConfig.Default()
vs. KubeadmConfig create with envtest// +kubebuilder:default
marker inKubeadmConfigSpec
struct and below (controller-tools based linter)/kind feature /area control-plane