search

kubernetes-sigs / container-object-storage-interface-controller

Container Object Storage Interface (COSI) controller responsible to manage lifecycle of COSI objects. NOTE: The content of this repo has been moved to https://github.com/kubernetes-sigs/container-object-storage-interface.
Apache License 2.0
94 stars 28 forks source link

bug 54: finalizer update fix #55

Closed krishchow closed 3 years ago

krishchow commented 3 years ago

This PR removes two calls for the BR and BAR Update, since instead we can a single UpdateStatus call to handle the update. This also fixes: #54

krishchow commented 3 years ago

Thanks for your help w/ debugging this @thotz

krishchow commented 3 years ago

/assign @wlan0

wlan0 commented 3 years ago

/lgtm

wlan0 commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishchow, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/container-object-storage-interface-controller/blob/master/OWNERS)~~ [wlan0] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment