search

kubernetes-sigs / dashboard-metrics-scraper

Container to scrape, store, and retrieve a window of time from the Metrics Server.
Apache License 2.0
87 stars 39 forks source link

Change sqlite db to use `/tmp/metrics.db` by default instead of `:memory:` #11

Closed jeefy closed 5 years ago

jeefy commented 5 years ago

Instability was observed by several using :memory: as the default backing database file. Changing the default to a tmp file seems appropriate.

jeefy commented 5 years ago

/approve

/lgtm

k8s-ci-robot commented 5 years ago

@jeefy: you cannot LGTM your own PR.

In response to [this](https://github.com/kubernetes-sigs/dashboard-metrics-scraper/pull/11#issuecomment-487331582): >/approve > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/dashboard-metrics-scraper/blob/master/OWNERS)~~ [jeefy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment