k8s-ci-robot
commented
4 years ago Welcome @FrenchBen!
It looks like this is your first PR to kubernetes-sigs/dashboard-metrics-scraper 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/dashboard-metrics-scraper has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
jeefy
When deploying the dashboard in a scoped namespace, metrics server will fail due to the Node lookup, as well as the cluster wide pod lookup. This allows scoping of the call to the target namespace(s), removing the node call when set.
Builder was also modified to include the
sqlite3cli package, providing a quick an easy way to list data in the db-file when running in a target build. Current image size:builder: 1.01GBfinal: 36.7MBNew image size:
builder: 1.01GBfinal: 36.7MB