search

kubernetes-sigs / dashboard-metrics-scraper

Container to scrape, store, and retrieve a window of time from the Metrics Server.
Apache License 2.0
87 stars 39 forks source link

Compile with netgo to enable DNS resolution #40

Closed Sh4d1 closed 3 years ago

Sh4d1 commented 3 years ago

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

Fixes #39

Sh4d1 commented 3 years ago

/assign @maciaszczykm Could we release a new version if this gets merged?

jeefy commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, Sh4d1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/dashboard-metrics-scraper/blob/master/OWNERS)~~ [jeefy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Sh4d1 commented 3 years ago

@jeefy can it be merged? Or waiting for another review? :)

jeefy commented 3 years ago

/lgtm I usually give courtesy time before I both lgtm and approve in case someone else has an opinion :)

Sh4d1 commented 3 years ago

Fair enough 😄 thanks! Will it be possible to cut a release with just this change ? 😄