Closed tumberino closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jtumber-ibm
Once this PR has been reviewed and has the lgtm label, please assign maciaszczykm for approval by writing /assign @maciaszczykm
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @jtumber-ibm!
It looks like this is your first PR to kubernetes-sigs/dashboard-metrics-scraper 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/dashboard-metrics-scraper has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Nice work! Can you please sign the CLA?
Nice work! Can you please sign the CLA?
Yeah, working on it but need to be added to IBM org for it.
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:
Use Docker buildx build tooling to create multi-arch manifest instead of manually adding images.
Test build: https://hub.docker.com/r/jamesnelson/metrics-scraper/tags
Fixes: #54
Signed-off-by: James Tumber james.tumber@ibm.com