kubernetes-sigs / dashboard-metrics-scraper

Container to scrape, store, and retrieve a window of time from the Metrics Server.
Apache License 2.0
87 stars 39 forks source link

Use buildx for cross-platform builds #55

Closed tumberino closed 1 year ago

tumberino commented 1 year ago

Use Docker buildx build tooling to create multi-arch manifest instead of manually adding images.

Test build: https://hub.docker.com/r/jamesnelson/metrics-scraper/tags

Fixes: #54

Signed-off-by: James Tumber james.tumber@ibm.com

linux-foundation-easycla[bot] commented 1 year ago

CLA Not Signed

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jtumber-ibm Once this PR has been reviewed and has the lgtm label, please assign maciaszczykm for approval by writing /assign @maciaszczykm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/dashboard-metrics-scraper/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

Welcome @jtumber-ibm!

It looks like this is your first PR to kubernetes-sigs/dashboard-metrics-scraper 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/dashboard-metrics-scraper has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

floreks commented 1 year ago

Nice work! Can you please sign the CLA?

tumberino commented 1 year ago

Nice work! Can you please sign the CLA?

Yeah, working on it but need to be added to IBM org for it.

k8s-ci-robot commented 1 year ago

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).