search

kubernetes-sigs / e2e-framework

A Go framework for end-to-end testing of components running in Kubernetes clusters.
Apache License 2.0
529 stars 103 forks source link

Resolve issue #369 by eliminating the redundant invocation of cfg.client.RestConfig in CreateClusterWithConfig, which is leading to a panic #372

Closed reetasingh closed 10 months ago

reetasingh commented 10 months ago

What type of PR is this?

/kind bug /kind regression

What this PR does / why we need it:

Remove unnecessary call to cfg.client.RestConfig in CreateClusterWithConfig . The cfg.Client() function expects cfg.kubeconfig to be set before calling. This is raising panic. Also the cfg.Client().RESTConfig() returns a restconfig which is not used anywhere in that function.

Which issue(s) this PR fixes:

Fixes # https://github.com/kubernetes-sigs/e2e-framework/issues/369

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., Usage docs, etc.:

k8s-ci-robot commented 10 months ago

Hi @reetasingh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
harshanarayana commented 10 months ago

/lgtm

harshanarayana commented 10 months ago

/ok-to-test

harshanarayana commented 10 months ago

/retest

harshanarayana commented 10 months ago

/approve

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshanarayana, reetasingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/e2e-framework/blob/main/OWNERS)~~ [harshanarayana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshanarayana commented 9 months ago

fixes #369 369