kubernetes-sigs / e2e-framework

A Go framework for end-to-end testing of components running in Kubernetes clusters.
Apache License 2.0
529 stars 103 forks source link

add cpanato as approver and move spiffxp to emeritus_approvers also order alphabetically #398

Closed cpanato closed 7 months ago

cpanato commented 7 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

/assign @vladimirvivien @ShwethaKumbla @harshanarayana

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., Usage docs, etc.:

harshanarayana commented 7 months ago

/lgtm

vladimirvivien commented 7 months ago

/lgtm

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/e2e-framework/blob/main/OWNERS)~~ [vladimirvivien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment