klient/decoder: add filename context to decode error

kubernetes-sigs / e2e-framework

A Go framework for end-to-end testing of components running in Kubernetes clusters.

Apache License 2.0

526 stars 101 forks source link

klient/decoder: add filename context to decode error #419

Closed sttts closed 6 months ago

sttts commented 6 months ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

When decoding fails, the decoder has no knowledge about the filename, but DecodeEachFile has. The later should add it to the error context.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., Usage docs, etc.:

harshanarayana commented 6 months ago

/lgtm

harshanarayana commented 6 months ago

/approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, harshanarayana, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/e2e-framework/blob/main/OWNERS)~~ [cpanato,harshanarayana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment