search

kubernetes-sigs / e2e-framework

A Go framework for end-to-end testing of components running in Kubernetes clusters.
Apache License 2.0
526 stars 101 forks source link

add teardown when TestExecPod finished #436

Closed googs1025 closed 4 months ago

googs1025 commented 4 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., Usage docs, etc.:

None
vladimirvivien commented 4 months ago

@googs1025 Thanks for the work. Is this meant to be a fix in the framework code or an update in the example only ? I only see an update to the example code.

googs1025 commented 4 months ago

@googs1025 Thanks for the work. Is this meant to be a fix in the framework code or an update in the example only ? I only see an update to the example code.

Yes, I just modified the code in the example.

vladimirvivien commented 4 months ago

@googs1025 ok thanks. Since this is just an example. Can you retitle the PR and remove "fix" ? I thought this was a fix for a bug. Thanks.

googs1025 commented 4 months ago

@googs1025 ok thanks. Since this is just an example. Can you retitle the PR and remove "fix" ? I thought this was a fix for a bug. Thanks.

OK, thanks for the comment. done

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/e2e-framework/blob/main/OWNERS)~~ [vladimirvivien] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment