search

kubernetes-sigs / external-dns

Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services
Apache License 2.0
7.75k stars 2.58k forks source link

feat(pdns): add validation for MX and SRV records #4871

Open julillae opened 2 weeks ago

julillae commented 2 weeks ago

Description Adds a check to validate the format of MX and SRV records. In addition, implements AdjustEndpoints to filter incorrectly formatted records which we know will fail to be created by PowerDNS. This change improves error handling for MX and SRV records and provides a base to validate other record types in the future.

Fixes #ISSUE

Checklist

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/external-dns/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 weeks ago

Hi @julillae. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mloiseleur commented 2 weeks ago

Thanks for this PR, which is tested. I'm wondering: the format check based on RFC may be used by other providers. Wdyt of moving the checkEndpoint part in endpoint/endpoint.go ?

mloiseleur commented 2 weeks ago

/retitle feat(pdns): add validation for MX and SRV records

julillae commented 1 week ago

@mloiseleur That is a great point! I moved the checkEndpoint function to endpoint/endpoint.go.