kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
526 stars 173 forks source link

metric karpenter_disruption_actions_performed_total does have value #1413

Closed hitsub2 closed 2 weeks ago

hitsub2 commented 1 month ago

Description

Observed Behavior: The karpenter_disruption_actions_performed_total is alway empty when there is disruption happened.

Expected Behavior: karpenter_disruption_actions_performed_total should have value

Reproduction Steps (Please include YAML):

Spot interruption by AWS FIS, karpenter performing node evict and delete the node. But this metrics does not have any value.

Versions:

jmdeal commented 1 month ago

Karpenter's disruption metrics refer to voluntary disruption, e.g. drift, expiration, consolidation, and emptiness. Spot interruption is involuntary and not considered a disruption action. For the AWS provider at least, spot interruption can be tracked with this metric.

/triage accepted /kind support

jmdeal commented 1 month ago

/remove-kind bug

hitsub2 commented 1 month ago

but ccording to the docs, spot interruption is just a method of disruption.

github-actions[bot] commented 1 month ago

This issue has been inactive for 14 days. StaleBot will close this stale issue after 14 more days of inactivity.