kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.55k stars 1.57k forks source link

Fix: update wait command for nginx ingress setup #3773

Open ShaikYams97 opened 3 weeks ago

ShaikYams97 commented 3 weeks ago

This pull request updates the wait command in the nginx ingress setup documentation to address timing issues on slower systems. The original documentation suggested waiting for the ingress controller pod readiness, but did not account for the time required for ingress-nginx-admission-patch and ingress-nginx-admission-create jobs to complete, especially on slower networks or systems.

Changes:

1.)Added a command to wait for the ingress-nginx-admission-patch job to complete before checking the readiness of the ingress controller. 2.)Updated command sequence: kubectl wait --namespace ingress-nginx \ --for=condition=complete job/ingress-nginx-admission-patch \ --timeout=30s \ && \ kubectl wait --namespace ingress-nginx \ --for=condition=ready pod \ --selector=app.kubernetes.io/component=controller \ --timeout=90s This improvement will prevent premature command errors (such as no matching resources found) by ensuring the patch job has completed before readiness is checked.

Issue Reference: Resolves #2293

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShaikYams97 Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kind/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 weeks ago

Welcome @ShaikYams97!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

Hi @ShaikYams97. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.