search

kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.55k stars 1.57k forks source link

update ingress docs #3787

Closed aojea closed 2 weeks ago

aojea commented 2 weeks ago

The existing manifest was not updated, we need to wait for a new rrelease but until then, it is better we host it ourselves so the guide works correctly.

In addition, remove a comment that no longer applies since current configuration of Ingress uses only standard options.

Tested locally

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kind/blob/main/OWNERS)~~ [aojea] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aojea commented 2 weeks ago

/assign @BenTheElder @stmcginnis

stmcginnis commented 2 weeks ago

Great!

/lgtm