kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

Consider Homebrew as the macOS distribution method #475

Open ahmetb opened 4 years ago

ahmetb commented 4 years ago

It seems like Krew was added to Homebrew formulae list. and it's currently available to users. Without documenting it, I suspect most people won't install it via brew.

Sadly, Krew is designed to install and update itself, just like any other kubectl plugin. We don't wish to support installation via other package managers as krew is a package manager itself (and while Krew is cross-platform, others aren't).

Homebrew makes sense for binaries like kubectl, but krew has extra installation instructions.

My recommendation would be to get Krew removed from Homebrew in the short term. Any help is appreciated.

/priority P1

glensc commented 4 years ago

Created draft PR for removal: https://github.com/Homebrew/homebrew-core/pull/49428

holler there if it's decided removal is the way to proceed.

glensc commented 4 years ago

@ahmetb PS: I'd prefer if you just ping me using @glensc handle rather send a private email. thanks.

ahmetb commented 4 years ago

Sorry about that I wasn't planning on creating an issue initially here.

ahmetb commented 4 years ago

So according to the discussion at https://github.com/Homebrew/homebrew-core/pull/49428:

For the short term, I recommend we take these actions:

It seems like organically we got >400 downloads on Homebrew in the past 30-days alone. We might make it the recommended solution if or when:

Until then we don't document Homebrew, but we also don't prevent users from using it.

⚠️ That said, I don't want this to set a precedent for other OSes/Distros:

I am negative about not being able to control distribution of a pre-1.0 software like this. I don't want us to maintain 5 different Linux distro package managers as well as Windows (Chocolatey). That's something Kubernetes project in general does not do (and it is deferred to the user community to package it up).

/retitle Consider Homebrew as the macOS distribution method

/area platform/mac /area distribution

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

ahmetb commented 4 years ago

/lifecycle frozen