search

kubernetes-sigs / krew

📦 Find and install kubectl plugins
https://krew.sigs.k8s.io
Apache License 2.0
6.42k stars 369 forks source link

Mention `KREW_ROOT` on instruction #774

Closed JohnTitor closed 2 years ago

JohnTitor commented 2 years ago

Related issue: #767 The instruction on https://github.com/kubernetes-sigs/krew/blob/93827db2b9954e356456f24cc030419a899e95b1/hack/krew.yaml#L13-L16 mentions KREW_ROOT but one on cmd/krew/cmd/internal/setup_check.go doesn't. This tweaks that instruction to mention KREW_ROOT there too. The fish command is a bit long as there's no simple alternative to the unset variables on fish AFAIK.

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 2 years ago

Welcome @JohnTitor!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

JohnTitor commented 2 years ago

/assign @ahmetb

ahmetb commented 2 years ago

this is not worth changing just because of krew completion (which we've removed since) but I think it's ok since the install guide already offers this functionality https://krew.sigs.k8s.io/docs/user-guide/setup/install/ (though the zsh cmd doesn't use the KREW_ROOT as you noted here).

ahmetb commented 2 years ago

/lgtm /approve Thanks!

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, JohnTitor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/krew/blob/master/OWNERS)~~ [ahmetb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment