Closed des1redState closed 1 year ago
Hi @des1redState. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@des1redState Hi, Thank you for your PR! Could you check this comment? I think that this PR looks good.
/ok-to-test
Thanks @196Ikuchil - I've completed the EasyCLA enrolment now. Is it possible to re-trigger that particular test please? (apologies, it's my first time contributing).
Thanks @des1redState ! Sorry, there was one more point. Please check this comment and fix to commit message?
/retest
/retitle Bump etcd to v3.4.26
@des1redState: Re-titling can only be requested by trusted users, like repository collaborators.
@196Ikuchil I've edited the title to remove the illegal keyword. Thanks.
/retest
@des1redState you need to change the commit as it suggested https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/316#issuecomment-1666827057
❌ The email address for the commit (https://github.com/kubernetes-sigs/kube-scheduler-simulator/commit/b4457633e6ef779c0e53cef973a2de7908d7e6c5) is not linked to the GitHub account, preventing the EasyCLA check.
Also please make sure you associate the correct email to your commit https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/316#issuecomment-1666442998
Sorry about that @sanposhiho - all resolved now.
@des1redState Thank you for your PR!
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 196Ikuchil, des1redState
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Fixes #308
/area simulator /kind bug /label tide/merge-method-squash