Closed 196Ikuchil closed 5 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 196Ikuchil
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Oops, I forgot to fix the externalscheduler
package as well.
/hold
/unhold
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
PR needs rebase.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/close
Taken over at https://github.com/kubernetes-sigs/kube-scheduler-simulator/pull/358
@sanposhiho: Closed this PR.
What type of PR is this?
/area simulator /kind feature
What this PR does / why we need it:
TODO
Which issue(s) this PR fixes:
Fixes #291
Results
Tested in my local.
(Formatted↓)
Special notes for your reviewer:
In order to resolve issue 318 in the near future, I'd like to split the
CreateOptionForOutOfTreePlugin()
process by purpose./assign @sanposhiho
/label tide/merge-method-squash