Closed sanposhiho closed 10 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/cc @196Ikuchil @utam0k
It seems you should replace sets.String
with sets.Set
. ref: https://github.com/kubernetes/kubernetes/issues/113709
scheduler/plugin/wrappedplugin_test.go:1295:49: cannot use sets.NewString("hoge") (value of type sets.String) as sets.Set[string] value in struct literal (typecheck)
want: &framework.PreFilterResult{NodeNames: sets.NewString("hoge")},
I'm pleased to review this PR, so please let me know when it becomes ready.
/retest
/retest
Well, why is the linting job endless.
/retest
/retest
It took me a thousand years, finally the linter issue is somehow resolved by changing the way to install golangci-lint 🤷 .
@utam0k @196Ikuchil Give it /lgtm
when get a chance.
/lgtm
Thanks
What type of PR is this?
/area simulator /kind feature
What this PR does / why we need it:
upgrade Kubernetes version to v0.28.5.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/label tide/merge-method-squash