search

kubernetes-sigs / kube-scheduler-simulator

The simulator for the Kubernetes scheduler
Apache License 2.0
799 stars 138 forks source link

Simulate scheduler with debuggable scheduler container #370

Closed YamasouA closed 1 month ago

YamasouA commented 3 months ago

What type of PR is this?

/kind

What this PR does / why we need it:

Enable the server to restart the scheduler.

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/kube-scheduler-simulator/issues/318

Special notes for your reviewer:

/assign @sanposhiho

/label tide/merge-method-squash

k8s-ci-robot commented 3 months ago

Hi @YamasouA. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sanposhiho commented 2 months ago

/ok-to-test

sanposhiho commented 2 months ago

/priority next-release

@YamasouA Please ping me when it's ready to review again!

YamasouA commented 2 months ago

@sanposhiho Please review again!

YamasouA commented 1 month ago

@sanposhiho I have addressed your comments, so could you please review again?

YamasouA commented 1 month ago

@sanposhiho I updated how-it-works.md in this commit. 81cc8ef And, other comments for code is also fix.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, YamasouA

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment