feature: set up the scheduler with wasm plugin

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.

Apache License 2.0

86 stars 17 forks source link

feature: set up the scheduler with wasm plugin #18

Closed sanposhiho closed 11 months ago

sanposhiho commented 11 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Set up the scheduler with the wasm plugin.
- Move the wasm plugin directory under /scheduler/pkg/plugins.
Implement the plugin config for the wasm plugin.
- Need this to register the wasm plugin in app.WithPlugin

Which issue(s) this PR fixes:

Part of #9

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Set up the scheduler with the wasm plugin
- The plugin config for the wasm plugin is implemented.

sanposhiho commented 11 months ago

cc @codefromthecrypt

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, kerthcet, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [kerthcet,sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sanposhiho commented 11 months ago

/unhold

Yes, I meant to do this one.

codefromthecrypt commented 11 months ago

FYI, maybe GuestName might be optional as we can parse the .wasm file. Anyway, would not block this PR.

agree it is optional even if we parse the wasm file as only thing it does is improve logs