Closed sanposhiho closed 11 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt, sanposhiho
The full list of commands accepted by this bot can be found here.
The pull request process is described here
If the bot is using the GitHub API it probably reflects the repo settings, so it may be good to confirm what they look like. The setting is around here
does this limit the message to only the title of PR? GitHub has this feature now, and it is a lot nicer that a list of "broke, fixed, fuzz" etc.
It also has the commits like https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/commit/f801a888e637e897ddca822ae213780e30a89030
I just changed the setting to allow only squash merging, let's see how the bot works in another PR with this setting
maybe re-kick the action?
Well, seems we need to have the tide/merge-method-squash label anyway then to let the bot squash-merge the PR. 😓
@sanposhiho I'm not familiar with the bot but my guess would be you need to add /label tide/merge-method-squash
to this PR itself to switch it to non-merge mode
My concern is independent commits will also be squashed. Prefer to label that manually.
My concern is independent commits will also be squashed. Prefer to label that manually.
if we do well one PR is small enough that independent commits aren't needed. how about it?
Have a chat with @codefromthecrypt, let's keep as it is now. I'd close this.
/close
@sanposhiho: Closed this PR.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
have a label
tide/merge-method-squash
in all PRs via PR template. Instead of asking squash for authors, we can ask the bot to do squash merge.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
What are the benchmark results of this change?