kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
86 stars 17 forks source link

have a label tide/merge-method-squash in all PRs #33

Closed sanposhiho closed 11 months ago

sanposhiho commented 11 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

have a label tide/merge-method-squash in all PRs via PR template. Instead of asking squash for authors, we can ask the bot to do squash merge.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

What are the benchmark results of this change?

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anuraaga commented 11 months ago

If the bot is using the GitHub API it probably reflects the repo settings, so it may be good to confirm what they look like. The setting is around here image

sanposhiho commented 11 months ago

does this limit the message to only the title of PR? GitHub has this feature now, and it is a lot nicer that a list of "broke, fixed, fuzz" etc.

It also has the commits like https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/commit/f801a888e637e897ddca822ae213780e30a89030

sanposhiho commented 11 months ago

I just changed the setting to allow only squash merging, let's see how the bot works in another PR with this setting

Screenshot 2023-06-09 at 12 44 39
codefromthecrypt commented 11 months ago

Screenshot 2023-06-09 at 11 53 59

maybe re-kick the action?

sanposhiho commented 11 months ago

Well, seems we need to have the tide/merge-method-squash label anyway then to let the bot squash-merge the PR. 😓

anuraaga commented 11 months ago

@sanposhiho I'm not familiar with the bot but my guess would be you need to add /label tide/merge-method-squash to this PR itself to switch it to non-merge mode

kerthcet commented 11 months ago

My concern is independent commits will also be squashed. Prefer to label that manually.

codefromthecrypt commented 11 months ago

My concern is independent commits will also be squashed. Prefer to label that manually.

if we do well one PR is small enough that independent commits aren't needed. how about it?

sanposhiho commented 11 months ago

Have a chat with @codefromthecrypt, let's keep as it is now. I'd close this.

/close

k8s-ci-robot commented 11 months ago

@sanposhiho: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/33#issuecomment-1584084668): >Have a chat with @codefromthecrypt, let's keep as it is now. >I'd close this. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.