search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
86 stars 17 forks source link

deps: updates to TinyGo 0.28.1 #36

Closed codefromthecrypt closed 11 months ago

codefromthecrypt commented 11 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates to latest TinyGo which progresses its applicability to things including json and ASN code.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Minimum TinyGo is now latest TinyGo 0.28.1 (technically 0.28.0 is fine)

What are the benchmark results of this change?

goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e
                                       │ v0.27.0.txt  │            v0.28.1.txt             │
                                       │    sec/op    │   sec/op     vs base               │
PluginFilter/noop/params:_small-12       199.7n ± 14%   189.6n ± 2%   -5.06% (p=0.002 n=6)
PluginFilter/noop/params:_real-12        191.7n ±  3%   189.2n ± 1%   -1.30% (p=0.002 n=6)
PluginFilter/wasm/params:_small-12       6.869µ ±  2%   6.844µ ± 1%        ~ (p=0.180 n=6)
PluginFilter/wasm/params:_real-12        50.39µ ±  1%   50.57µ ± 1%        ~ (p=0.394 n=6)
PluginScore/noop/params:_small-12        241.8n ±  1%   243.2n ± 1%        ~ (p=0.327 n=6)
PluginScore/noop/params:_real-12         206.4n ±  1%   207.9n ± 0%   +0.73% (p=0.002 n=6)
PluginScore/wasm/params:_small-12        5.158µ ±  0%   3.918µ ± 1%  -24.03% (p=0.002 n=6)
PluginScore/wasm/params:_real-12         49.36µ ±  2%   51.76µ ± 2%   +4.85% (p=0.002 n=6)
k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codefromthecrypt, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/OWNERS)~~ [sanposhiho] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codefromthecrypt commented 11 months ago

Can we somehow tell users about the recommended tinygo version?

yeah. actually we are missing any info at all about building the guest, so when we make that we should also tell them about the tinygo version ;) I've personally delayed this until the functionality is a little farther because compiling guest locks in the ABI, which is moving still.

sanposhiho commented 11 months ago

until the functionality is a little farther because compiling guest locks in the ABI, which is moving still.

Sounds good. 🙆‍♂️