Closed codefromthecrypt closed 10 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codefromthecrypt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
ok I cleaned up the PR so that it is ready to merge if ok (backfilled test coverage and notes).
After this, we can add guest config (e.g. plugin to read yaml or otherwise) and PreScore, so we can implement a realistic, configurable plugin like nodenumber.
ok all good. bench should have become a little worse on noop, due to extra hook. Things look correct now.
@sanposhiho PTAL I think I got everything (pre-squashed)
New changes are detected. LGTM label has been removed.
thanks for the catch @sanposhiho!
/unhold
tomorrow I'll work on pre-score and hopefully config. after that, we should be able to port a basic plugin.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This implements
framework.EnqueueExtensions
which is needed for common sample plugins, such as nodenumberThis also reduces namespace conflicts by moving the guest code that is related to protos into its own package. Notably there's a conflict on the framework symbol
Node
and the proto type.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
What are the benchmark results of this change?