search

kubernetes-sigs / kube-scheduler-wasm-extension

All the things to make the scheduler extendable with wasm.
Apache License 2.0
110 stars 22 forks source link

Test framework support #8

Closed kerthcet closed 6 months ago

kerthcet commented 1 year ago

What would you like to be added:

We should have a test framework to run test suit each time we have new PRs. This requires the support from test infra

Why is this needed:

Project health and stability

Completion requirements:

This enhancement requires the following artifacts:

The artifacts should be linked in subsequent comments.

codefromthecrypt commented 1 year ago

Is this different than normal CI for unit tests?

kerthcet commented 1 year ago

Actually it will run the same unit test with similar commands but it will have a dashboard for tracing, both the history and the error if happens. We can get a overview of all the tests here https://testgrid.k8s.io/sig-scheduling#periodic-kueue-test-unit-main, including unit tests, integration tests, e2e tests if we have.

sanposhiho commented 1 year ago

Let's prioritize it. /priority important-soon

@kerthcet Could you work on it? 🙏

kerthcet commented 1 year ago

Yes /assign

codefromthecrypt commented 1 year ago

here is basic CI, we had several source files that were checked in even though they didn't compile https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/30

kerthcet commented 1 year ago

I did some research this weekend, the testgrid will read junit.xml artifacts for display. However we have multi modules, we can't generate a unified test report cover all the packages, it's a little tricky.

pohly commented 1 year ago

I'm not sure about the exact pattern, but I think Spyglass and testgrid read all junit*.xml files in the artifacts directory. You should be able to write one file per package.

sanposhiho commented 11 months ago

/remove-priority important-soon

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 6 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/issues/8#issuecomment-2134303185): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.