search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

chore: Refactor test helpers into reusable ktest library #398

Open justinsb opened 3 weeks ago

justinsb commented 3 weeks ago

This will avoid a circular (module) dependency between mockkubeapiserver and kdp itself.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 3 weeks ago

Sadly it looks like I can't start using this / remove the old pkg/test directories in the same PR.

I feel like I'm using modules "wrong", I guess we should be using a separate repo. Even if we were using a separate repo, we would have the same sequence of PRs, I guess.

justinsb commented 3 weeks ago

(This is breaking down #383 into its required commits)

justinsb commented 5 days ago

Cleaned this up, but let's try adding go.work in #383

justinsb commented 5 days ago

/hold