The control plane pre-update only implemented for docker

kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster

Apache License 2.0

16.22k stars 6.5k forks source link

The control plane pre-update only implemented for docker #11316

Open MOZGIII opened 5 months ago

MOZGIII commented 5 months ago

I was reading through the whole kubespray and noticed this inconsistency: other container runtimes can potentially be used, but forceful deletion is only implemented for docker.

https://github.com/kubernetes-sigs/kubespray/blob/24dc4cef56848c2efc3a9e050959f4feee92976a/roles/kubernetes/control-plane/tasks/pre-upgrade.yml#L1-L21

Is this an overlook, or is there a reason why this is done this way?

Looks like a bug to me, as it is not checked whether docker is even used at all.

Possible fixes:

Use crictl there to abstract around the runtime?
Run commands with nerdctl for containerd too?
?

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

MOZGIII commented 2 months ago

As usual with k8s stuff, you spend time and fill in the issue form just to get it thrown away and receive no attention... Maybe I shouldn't waste time like this anymore?..

/remove-lifecycle stale