kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.22k stars 6.5k forks source link

Move the CRI endpoint setting to kubelet config #11550

Closed VannTen closed 2 months ago

VannTen commented 2 months ago

What type of PR is this? /kind cleanup What this PR does / why we need it: The --container-runtime-endpoint kubelet argument is deprecated in favor of the config file alternative.

Special notes for your reviewer: Re-creating #11489 which is stuck on CI bug

Does this PR introduce a user-facing change?:

NONE
VannTen commented 2 months ago

/ok-to-test

VannTen commented 2 months ago

Needs a lgtm :)

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [VannTen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment