kubernetes-sigs / kubespray

Deploy a Production Ready Kubernetes Cluster
Apache License 2.0
16.22k stars 6.5k forks source link

Update containerd `containerd_max_container_log_line_size` default value to 16384 #11585

Closed KubeKyrie closed 2 months ago

KubeKyrie commented 2 months ago

What type of PR is this? /kind feature

What this PR does / why we need it: update containerd max_container_log_line_size default value to 16384.

See https://github.com/containerd/containerd/blob/main/docs/cri/config.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[need notice] update containerd `max_container_log_line_size` default value to 16384
k8s-ci-robot commented 2 months ago

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yankay commented 2 months ago

/ok-to-test

tico88612 commented 2 months ago

@yankay @VannTen Should it need to add action required in release note?

yankay commented 2 months ago

@yankay @VannTen Should it need to add action required in release note?

@KubeKyrie The default value is same as https://github.com/containerd/containerd/blob/main/internal/cri/config/config_unix.go#L94, so the change is OK. /approve The note can be more clear, like: "update containerd max_container_log_line_size default value to 16384 [need notice] ".

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KubeKyrie, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubespray/blob/master/OWNERS)~~ [yankay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tico88612 commented 2 months ago

/release-note-edit

[need notice] update containerd `max_container_log_line_size` default value to 16384

/lgtm

tico88612 commented 2 months ago

/retitle Update containerd containerd_max_container_log_line_size default value to 16384

tico88612 commented 2 days ago

/kind feature