Closed KubeKyrie closed 2 months ago
Hi @KubeKyrie. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@yankay @VannTen
Should it need to add action required
in release note?
@yankay @VannTen Should it need to add
action required
in release note?
@KubeKyrie
The default value is same as https://github.com/containerd/containerd/blob/main/internal/cri/config/config_unix.go#L94, so the change is OK.
/approve
The note can be more clear, like: "update containerd max_container_log_line_size
default value to 16384 [need notice] ".
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: KubeKyrie, yankay
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/release-note-edit
[need notice] update containerd `max_container_log_line_size` default value to 16384
/lgtm
/retitle Update containerd containerd_max_container_log_line_size
default value to 16384
/kind feature
What type of PR is this? /kind feature
What this PR does / why we need it: update containerd
max_container_log_line_size
default value to 16384.See https://github.com/containerd/containerd/blob/main/docs/cri/config.md
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: