Fix flag redefined panic error

Rajalakshmi-Girish commented 11 months ago

Merge of change https://github.com/kubernetes-sigs/kubetest2/pull/234 has introduced panic errors of below kind:

Error: /home/prow/go/bin/kubetest2-tester-ginkgo flag redefined: alsologtostderr
panic: /home/prow/go/bin/kubetest2-tester-ginkgo flag redefined: alsologtostderr
goroutine 1 [running]:
flag.(*FlagSet).Var(0xc000130120, {0x1e2da28, 0x2e0f129}, {0x1b0e848, 0xf}, {0x1b8ea78, 0x49})
    flag/flag.go:982 +0x2dc
k8s.io/klog/v2.InitFlags.func1(0xc000120480?)
    k8s.io/klog/v2@v2.100.1/klog.go:437 +0x4c
flag.(*FlagSet).VisitAll(0x55?, 0xc000c3fe10)
    flag/flag.go:447 +0x68
k8s.io/klog/v2.InitFlags(0x19ec5e0?)
    k8s.io/klog/v2@v2.100.1/klog.go:436 +0x60
sigs.k8s.io/kubetest2/pkg/testers/ginkgo.(*Tester).Execute(0x60?)
    sigs.k8s.io/kubetest2/pkg/testers/ginkgo/ginkgo.go:204 +0xa4
sigs.k8s.io/kubetest2/pkg/testers/ginkgo.Main()
    sigs.k8s.io/kubetest2/pkg/testers/ginkgo/ginkgo.go:256 +0x7c
main.main()
    sigs.k8s.io/kubetest2/kubetest2-tester-ginkgo/main.go:24 +0x24

The commit https://github.com/kubernetes-sigs/kubetest2/pull/234/commits/85dfb4e8e7f8503e3ea777e02f594e1e1807a753 seemed to have missed removing klog.InitFlags(nil) from tester files and noop deployer file.

dims commented 11 months ago

/approve /lgtm

dims commented 11 months ago

cc @upodroid

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, michelle192837, Rajalakshmi-Girish, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / kubetest2

Fix flag redefined panic error #235