kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Cherry pick #3536 and #3547 to 0.8 #3551

Closed gabesaba closed 1 week ago

gabesaba commented 1 week ago

Special notes for your reviewer:

I had to manually reimplement PotentiallyAvailable, as that was introduced with HierarchicalCohorts (0.9)

Does this PR introduce a user-facing change?

Change, and in some scenarios fix, the status message displayed to user when a workload doesn't fit in available capacity.
Determine borrowing more accurately, allowing preempting workloads which fit in nominal quota to schedule faster
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit fbe94e632b67839535c79a0b818bce394389e3ed
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67377bd8d96b430008d373d1
Deploy Preview https://deploy-preview-3551--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 1 week ago

LGTM label has been added.

Git tree hash: 55158586a7a73e3b57a1a8f15c5801face122253

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/release-0.8/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimowo commented 1 week ago

/kind bug

mimowo commented 1 week ago

/release-note-edit

Change, and in some scenarios fix, the status message displayed to user when a workload doesn't fit in available capacity.
Determine borrowing more accurately, allowing preempting workloads which fit in nominal quota to schedule faster

It presents better in the release notes without the "-" prefix (as the release notes list adds one already).