search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Optimize and extend deployment unit tests. #3556

Closed mbobrovskyi closed 1 week ago

mbobrovskyi commented 1 week ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Optimize and extend deployment unit tests.

Which issue(s) this PR fixes:

Prepare for #3555

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit e36eb4c72aa6171b36fa3ca8a35dc5586cc7da7d
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673afaf16f59ef0008323ec9
mbobrovskyi commented 1 week ago

/cc @mimowo

k8s-ci-robot commented 1 week ago

LGTM label has been added.

Git tree hash: 85af4ed2ad24bd4323aacdba09127091d95b356a

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controller/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/pkg/controller/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mbobrovskyi commented 1 week ago

Resolved conflicts.

mimowo commented 1 week ago

/lgtm

k8s-ci-robot commented 1 week ago

LGTM label has been added.

Git tree hash: 83b648d0d5f30d2b98879260b05bb4496b4d362f

mbobrovskyi commented 1 week ago

/cherry-pick release-0.9

k8s-infra-cherrypick-robot commented 1 week ago

@mbobrovskyi: new pull request created: #3579

In response to [this](https://github.com/kubernetes-sigs/kueue/pull/3556#issuecomment-2483102118): >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.